Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 327203002: Revert of DevTools: notify backend agents about profiler started/stopped events (Closed)

Created:
6 years, 6 months ago by loislo
Modified:
6 years, 6 months ago
Reviewers:
vsevik, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

Revert of DevTools: notify backend agents about profiler started/stopped events (https://codereview.chromium.org/321173002/) Reason for revert: We came to the conclusion that this patch moves us in a wrong direction. With this approach we would have to manage 4 pairs of states. Disabled+stopped, disabled+started, enabled+stopped, etc up to enabled+started :) in the each agent. So we would like to try the simplest one, just use enable/disable states and fix the problems related to them. Original issue's description: > DevTools: notify backend agents about profiler started/stopped events > > This patch provides a way to notify backend agents about starting a profiler. > Each agent should switch to a mode which doesn't affect the performance. > As example DebuggerAgent needs to disable breakpoints, allow v8 optimizations, etc. > DOM and Network agents may simple disable themselves. > > BUG=381115 > R=pfeldman@chromium.org > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175946 TBR=pfeldman@chromium.org,vsevik@chromium.org NOTREECHECKS=true NOTRY=true BUG=381115 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175954

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -41 lines) Patch
M Source/core/inspector/InspectorBaseAgent.h View 2 chunks +0 lines, -5 lines 0 comments Download
M Source/core/inspector/InspectorBaseAgent.cpp View 1 chunk +0 lines, -12 lines 0 comments Download
M Source/core/inspector/InspectorController.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorProfilerAgent.h View 3 chunks +2 lines, -3 lines 0 comments Download
M Source/core/inspector/InspectorProfilerAgent.cpp View 4 chunks +6 lines, -9 lines 0 comments Download
M Source/core/inspector/InspectorTimelineAgent.h View 3 chunks +3 lines, -4 lines 0 comments Download
M Source/core/inspector/InspectorTimelineAgent.cpp View 4 chunks +1 line, -4 lines 0 comments Download
M Source/core/inspector/WorkerInspectorController.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
loislo
Created Revert of DevTools: notify backend agents about profiler started/stopped events
6 years, 6 months ago (2014-06-11 12:17:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/loislo@chromium.org/327203002/1
6 years, 6 months ago (2014-06-11 12:17:43 UTC) #2
commit-bot: I haz the power
6 years, 6 months ago (2014-06-11 12:18:41 UTC) #3
Message was sent while issue was closed.
Change committed as 175954

Powered by Google App Engine
This is Rietveld 408576698