Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 327133002: Intorudce DECLARE/DEFINE_ELEMENT_FACTORY_WITH_TAGNAME macros. (Closed)

Created:
6 years, 6 months ago by tkent
Modified:
6 years, 6 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, ed+blinkwatch_opera.com, blink-reviews-html_chromium.org, sof, eae+blinkwatch, fs, blink-reviews-dom_chromium.org, dglazkov+blink, krit, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, kouhei+svg_chromium.org, pdr., rwlbuis
Visibility:
Public.

Description

Introduce DECLARE/DEFINE_ELEMENT_FACTORY_WITH_TAGNAME macros. They generate Element factory function like |PassRefPtrWillBeRawPtr<T> create(const QualifiedName&, Document&)|. We're going to change element factories at least twice. 1. Replace adoptRefWillBeRefCountedGarbageCollected with adoptRefWillBeNoop 2-1. Replace PassRefPtrWillBeRawPtr<T> with T* and remove adoptRefWillBeNoop if we switch to Oilpan successfully. 2-2. Replace PassRefPtrWillBeRawPtr<T> with PassRefPtr<T>, and adoptRefWillBeNoop with adoptRef if we decide not to switch Oilpan. This CL makes these changes easier. BUG=357163 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175940

Patch Set 1 #

Patch Set 2 : Fix a duplicated symbol issue #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -45 lines) Patch
M Source/core/dom/Element.h View 1 chunk +8 lines, -0 lines 0 comments Download
M Source/core/html/HTMLElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLElement.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M Source/core/html/HTMLHeadingElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLHeadingElement.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M Source/core/html/HTMLModElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLModElement.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M Source/core/html/HTMLPreElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLPreElement.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M Source/core/html/HTMLQuoteElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLQuoteElement.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M Source/core/html/HTMLTableCellElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTableCellElement.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M Source/core/html/HTMLTableColElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTableColElement.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M Source/core/html/HTMLTableSectionElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTableSectionElement.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M Source/core/svg/SVGUnknownElement.h View 1 chunk +1 line, -4 lines 0 comments Download
M Source/core/svg/SVGUnknownElement.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
tkent
Please review this. This is similar to https://codereview.chromium.org/327633004/
6 years, 6 months ago (2014-06-11 00:44:45 UTC) #1
haraken
LGTM
6 years, 6 months ago (2014-06-11 00:48:26 UTC) #2
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 6 months ago (2014-06-11 01:21:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/327133002/20001
6 years, 6 months ago (2014-06-11 01:21:32 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 6 months ago (2014-06-11 02:44:42 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-11 03:52:15 UTC) #6
Message was sent while issue was closed.
Change committed as 175940

Powered by Google App Engine
This is Rietveld 408576698