Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(840)

Unified Diff: runtime/vm/isolate.cc

Issue 327123002: At shutdown, remove isolate from list before tearing it down. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/isolate.cc
===================================================================
--- runtime/vm/isolate.cc (revision 37205)
+++ runtime/vm/isolate.cc (working copy)
@@ -767,6 +767,10 @@
ASSERT(top_resource() == NULL);
ASSERT((heap_ == NULL) || heap_->Verify());
+ // Remove this isolate from the list *before* we start tearing it down, to
+ // avoid exposing it in a state of decay.
+ RemoveIsolateFromList(this);
+
// Create an area where we do have a zone and a handle scope so that we can
// call VM functions while tearing this isolate down.
{
@@ -810,7 +814,6 @@
// TODO(5411455): For now just make sure there are no current isolates
// as we are shutting down the isolate.
SetCurrent(NULL);
- RemoveIsolateFromList(this);
Profiler::ShutdownProfilingForIsolate(this);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698