Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 327033002: Extract code into functions in GpuMain. (Closed)

Created:
6 years, 6 months ago by Jorge Lucangeli Obes
Modified:
6 years, 6 months ago
Reviewers:
piman
CC:
chromium-reviews, piman+watch_chromium.org, jam, darin-cc_chromium.org
Visibility:
Public.

Description

Extract code into functions in GpuMain. This makes the code clearer, and will make simplifying GPU sandbox init easier. BUG=356959 TEST=content_shell loads webpages. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276621

Patch Set 1 #

Patch Set 2 : Fix compile errors on non-Linux. #

Patch Set 3 : Really fix compile. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -50 lines) Patch
M content/gpu/gpu_main.cc View 1 2 6 chunks +79 lines, -50 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Jorge Lucangeli Obes
Hi Antoine, Extracting this code into functions makes GpuMain slightly less crazy, which will make ...
6 years, 6 months ago (2014-06-10 19:53:49 UTC) #1
piman
lgtm
6 years, 6 months ago (2014-06-10 22:04:36 UTC) #2
Jorge Lucangeli Obes
The CQ bit was checked by jorgelo@chromium.org
6 years, 6 months ago (2014-06-10 23:59:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jorgelo@chromium.org/327033002/1
6 years, 6 months ago (2014-06-11 00:02:59 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 06:08:46 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 06:20:45 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/builds/150904)
6 years, 6 months ago (2014-06-11 06:20:46 UTC) #7
Jorge Lucangeli Obes
The CQ bit was checked by jorgelo@chromium.org
6 years, 6 months ago (2014-06-12 05:34:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jorgelo@chromium.org/327033002/40001
6 years, 6 months ago (2014-06-12 05:38:49 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 11:00:48 UTC) #10
Message was sent while issue was closed.
Change committed as 276621

Powered by Google App Engine
This is Rietveld 408576698