Issue 327007: Revert 29861 since this fail on the interactive...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 327007: Revert 29861 since this fail on the interactive... (Closed)

Created:
11 years, 2 months ago by Finnur

Modified:
9 years, 6 months ago

Reviewers:
Nicolas Sylvain

CC:
chromium-reviews_googlegroups.com, Aaron Boodman, Erik does not do reviews, ben+cc_chromium.org, pam+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Revert 29861 since this fail on the interactive linux dbg bot, for some weird reason... Page actions that don't specify an icon (ie. have a spelling error in the manifest, such as icon instead of icons/default_icon) caused a crash when they try to display their icon. We now check when the extension tries to enable the page action whether there are any icons to display. If not, we don't proceed and log an error to the console. TBR=nsylvain BUG=25562 TEST=Covered by browser test. Review URL: http://codereview.chromium.org/316018 TBR=finnur@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29867

Patch Set 1 #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -91 lines)			Patch
M	chrome/browser/extensions/extension_browsertests_misc.cc	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/extensions/extension_page_actions_module.cc	View	3 chunks	+17 lines, -14 lines	0 comments	Download
M	chrome/browser/gtk/location_bar_view_gtk.cc	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	chrome/browser/views/location_bar_view.cc	View	2 chunks	+1 line, -10 lines	0 comments	Download
D	chrome/test/data/extensions/browsertest/crash_25562/background.html	View	1 chunk	+0 lines, -28 lines	0 comments	Download
D	chrome/test/data/extensions/browsertest/crash_25562/chrome-16.png	View	Binary file		0 comments	Download
D	chrome/test/data/extensions/browsertest/crash_25562/manifest.json	View	1 chunk	+0 lines, -17 lines	0 comments	Download
D	chrome/test/data/extensions/browsertest/crash_25562/script.js	View	1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages