[AiS] Add a new AutocompleteMatchType for Answers in Suggest.

chrome/browser/autocomplete/autocomplete_match.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/autocomplete/autocomplete_match.h"
 
 #include "base/i18n/time_formatting.h"
 #include "base/logging.h"
 #include "base/strings/string16.h"
 #include "base/strings/string_number_conversions.h"
@@ skipping 139 matching lines @@
     IDR_OMNIBOX_SEARCH,
     IDR_OMNIBOX_SEARCH,
     IDR_OMNIBOX_SEARCH,
     IDR_OMNIBOX_SEARCH,
     IDR_OMNIBOX_SEARCH,
     IDR_OMNIBOX_SEARCH,
     IDR_OMNIBOX_EXTENSION_APP,
     IDR_OMNIBOX_SEARCH,
     IDR_OMNIBOX_HTTP,
     IDR_OMNIBOX_HTTP,
+    IDR_OMNIBOX_SEARCH,
   };
   COMPILE_ASSERT(arraysize(icons) == AutocompleteMatchType::NUM_TYPES,
                  icons_array_must_match_type_enum);
   return icons[type];
 }
 
 // static
 int AutocompleteMatch::TypeToLocationBarIcon(Type type) {
   int id = TypeToIcon(type);
   if (id == IDR_OMNIBOX_HTTP)
@@ skipping 162 matching lines @@
          type == AutocompleteMatchType::SEARCH_SUGGEST ||
          type == AutocompleteMatchType::SEARCH_OTHER_ENGINE ||
          IsSpecializedSearchType(type);
 }
 
 // static
 bool AutocompleteMatch::IsSpecializedSearchType(Type type) {
   return type == AutocompleteMatchType::SEARCH_SUGGEST_ENTITY ||
          type == AutocompleteMatchType::SEARCH_SUGGEST_INFINITE ||
          type == AutocompleteMatchType::SEARCH_SUGGEST_PERSONALIZED ||
-         type == AutocompleteMatchType::SEARCH_SUGGEST_PROFILE;
+         type == AutocompleteMatchType::SEARCH_SUGGEST_PROFILE ||
+         type == AutocompleteMatchType::SEARCH_SUGGEST_ANSWER;

[Peter Kasting, 2014/06/10 21:49:46]

The effect of putting this here will be that the ShortcutsProvider, on seeing
the user hit enter on one of these matches, will instead create a shortcut entry
for a standard search that uses the search terms that triggered this match.

In other words, if I type in "foo", and I get an Answer, and I hit enter on it,
from the ShortcutsProvider perspective this will be treated like I did a search
for "foo".

I don't know whether this is what you want or not.

[Justin Donnelly, 2014/06/11 15:51:53]

Well, hitting enter on an Answer for "foo" will, in fact, search for "foo" so
this might be what I want.  But what's the alternative?  In other words, what's
the effect of putting the raw match into the shortcuts backend?

[Peter Kasting, 2014/06/11 17:02:02]

The alternative is that you get back a match exactly like the one that went it. 
So, I type "foo", I get an Answer, I hit enter on it, it searches for "foo". 
Now the next time I type "f", the shortcuts system returns the "Answer for foo"
match.

With the other specialized search results we've decided this isn't really what
we want, that instead, the act of "hitting enter on this means search for foo"
should result in the shortcuts system promoting "search for foo" in the future. 
I think that's probably appropriate for you as well.

 }
 
 void AutocompleteMatch::ComputeStrippedDestinationURL(Profile* profile) {
   stripped_destination_url = destination_url;
   if (!stripped_destination_url.is_valid())
     return;
 
   // If the destination URL looks like it was generated from a TemplateURL,
   // remove all substitutions other than the search terms.  This allows us
   // to eliminate cases like past search URLs from history that differ only
@@ skipping 149 matching lines @@
         << " is unsorted in relation to last offset of " << last_offset
         << ". Provider: " << provider_name << ".";
     DCHECK_LT(i->offset, text.length())
         << " Classification of [" << i->offset << "," << text.length()
         << "] is out of bounds for \"" << text << "\". Provider: "
         << provider_name << ".";
     last_offset = i->offset;
   }
 }
 #endif