Issue 326943002: Simplify string copy in SubStringStub.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 326943002: Simplify string copy in SubStringStub. (Closed)

Created:
6 years, 6 months ago by Yang

Modified:
6 years, 6 months ago

Reviewers:
Benedikt Meurer

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Simplify string copy in SubStringStub. The optimizations are unnecessary since the maximum string length they operate on is currently 12. R=bmeurer@chromium.org BUG=352155 LOG=N Committed: https://code.google.com/p/v8/source/detail?r=21756

Patch Set 1 #

Total comments: 1

Patch Set 2 : addressed comment #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+70 lines, -241 lines)			Patch
M	src/arm/code-stubs-arm.h	View	1	1 chunk	+6 lines, -9 lines	0 comments	Download
M	src/arm/code-stubs-arm.cc	View	1	3 chunks	+23 lines, -128 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.h	View		1 chunk	+6 lines, -6 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View		4 chunks	+20 lines, -51 lines	0 comments	Download
M	src/x64/code-stubs-x64.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/code-stubs-x64.cc	View		5 chunks	+14 lines, -46 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Benedikt Meurer

https://codereview.chromium.org/326943002/diff/1/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): https://codereview.chromium.org/326943002/diff/1/src/arm/code-stubs-arm.cc#newcode3329 src/arm/code-stubs-arm.cc:3329: Register scratch1, We need only one scratch register now, ...

6 years, 6 months ago (2014-06-11 04:04:29 UTC) #3

Yang

6 years, 6 months ago (2014-06-11 06:59:37 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r21756 (presubmit successful).

Expand Messages | Collapse Messages