Issue 326933002: [SyncFS] Initialize SyncEngine::remote_change_processor_ in the constructor - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(673)

My Issues | Starred Open | Closed | All

Issue 326933002: [SyncFS] Initialize SyncEngine::remote_change_processor_ in the constructor (Closed)

Created:
6 years, 6 months ago by tzik

Modified:
6 years, 6 months ago

Reviewers:
peria

CC:
chromium-reviews, kinuko+fileapi, nhiroki, tzik

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[SyncFS] Initialize SyncEngine::remote_change_processor_ in the constructor This should fix a memory error spotted by: http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28valgrind%29%285%29/builds/28092/steps/memory%20test%3A%20unit/logs/8E6AD1C2FCE494CD BUG=347425, 380615 NOTRY=true TBR=peria@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276000

Patch Set 1 #

Patch Set 2 : buildfix #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	chrome/browser/sync_file_system/drive_backend/sync_engine.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/326933002/20001

6 years, 6 months ago (2014-06-10 12:29:26 UTC) #3

Message was sent while issue was closed.

Change committed as 276000

Expand Messages | Collapse Messages

Powered by Google App Engine

This is Rietveld 408576698