MIPS: added optimization for functions from SkBlitRow.

MIPS: added optimization for functions from SkBlitRow.

gain is ~40%

following function are optimized:
  S32_D565_Blend
  S32A_D565_Opaque_Dither
  S32_D565_Opaque_Dither
  S32_D565_Blend_Dither
  S32A_D565_Opaque
  S32A_D565_Blend
  S32_Blend_BlitRow32

Committed: https://skia.googlesource.com/skia/+/632a4546b085fea79f40212935e5ac6fa74612a2

[djordje, 2014-06-10 12:59:29]

available options:
export GYP_DEFINES="skia_warnings_as_errors=1 mips_arch_variant=mips32r2"
export GYP_DEFINES="skia_warnings_as_errors=1 mips_arch_variant=mips32r2
mips_dsp=1"
export GYP_DEFINES="skia_warnings_as_errors=1 mips_arch_variant=mips32r2
mips_dsp=2"

[djsollen, 2014-06-10 15:46:07]

https://codereview.chromium.org/326913004/diff/1/gyp/opts.gyp
File gyp/opts.gyp (right):

https://codereview.chromium.org/326913004/diff/1/gyp/opts.gyp#newcode114
gyp/opts.gyp:114: 'conditions': [
I looks like you want this to work for all mips32r2 devices. If so, I think this
conditions can be simplified to be...

'conditions': [
  [ 'mips_arch_variant == "mips32r2"' {
    'dependencies': [
      'opts_dsp',
    ]
  }, { #else
    'sources': [
      '../src/opts/SkBlitRow_opts_none.cpp',
    ]
  }],
]

https://codereview.chromium.org/326913004/diff/1/gyp/opts.gyp#newcode261
gyp/opts.gyp:261: 'cflags!': [
remove the empty blocks

[djordje, 2014-06-10 16:39:17]

https://codereview.chromium.org/326913004/diff/1/gyp/opts.gyp
File gyp/opts.gyp (right):

https://codereview.chromium.org/326913004/diff/1/gyp/opts.gyp#newcode114
gyp/opts.gyp:114: 'conditions': [
no, it can not be done in this way since there is mips32r2 platforms without dsp
and optimizations should not be included for them. for now, there is two
versions of dsp and mips32r2 is essential for them. for these optimizations arch
must be mips32r2 and dsp must be 1 or 2.

[djsollen, 2014-06-10 17:49:56]

https://codereview.chromium.org/326913004/diff/1/gyp/opts.gyp
File gyp/opts.gyp (right):

https://codereview.chromium.org/326913004/diff/1/gyp/opts.gyp#newcode114
gyp/opts.gyp:114: 'conditions': [
On 2014/06/10 16:39:17, djordje wrote:
> no, it can not be done in this way since there is mips32r2 platforms without
dsp
> and optimizations should not be included for them. for now, there is two
> versions of dsp and mips32r2 is essential for them. for these optimizations
arch
> must be mips32r2 and dsp must be 1 or 2. 

Gotcha.  You should still update this to look like my suggestion (e.g. using an
else clause), but can keep the more complex condition.

https://codereview.chromium.org/326913004/diff/1/gyp/opts.gyp#newcode250
gyp/opts.gyp:250: 'target_name': 'opts_dsp',
do you intend to make using the dsp optimized code runtime optional?  If not,
there is no need for a separate target as this file can just be included where
you reference this dependency above.

[djordje, 2014-06-10 18:30:18]

https://codereview.chromium.org/326913004/diff/1/gyp/opts.gyp
File gyp/opts.gyp (right):

https://codereview.chromium.org/326913004/diff/1/gyp/opts.gyp#newcode250
gyp/opts.gyp:250: 'target_name': 'opts_dsp',
there will be no runtime detection. this part will be included above.

[djsollen, 2014-06-11 13:41:00]

lgtm. I don't expect the trybot to have any issues as it won't exercise the
optimized code path.  If we were to add additional trybot builders what is the
most common config? mips32r2 with dsp2?  Or some other combination?

[djordje, 2014-06-11 13:44:17]

On 2014/06/11 13:41:00, djsollen wrote:
> lgtm. I don't expect the trybot to have any issues as it won't exercise the
> optimized code path.  If we were to add additional trybot builders what is the
> most common config? mips32r2 with dsp2?  Or some other combination?

the most common config is mips32r2 with dsp2:
 export GYP_DEFINES="skia_warnings_as_errors=1 mips_arch_variant=mips32r2
mips_dsp=2"
other available configs are:
 export GYP_DEFINES="skia_warnings_as_errors=1 mips_arch_variant=mips32r2"
 export GYP_DEFINES="skia_warnings_as_errors=1 mips_arch_variant=mips32r2
mips_dsp=1"

[djordje, 2014-06-11 13:44:36]

The CQ bit was checked by djordje.pesut@imgtec.com

[commit-bot: I haz the power, 2014-06-11 13:45:09]

CQ is trying da patch. Follow status at

https://skia-tree-status.appspot.com/cq/djordje.pesut@imgtec.com/326913004/20001

[djsollen, 2014-06-11 13:56:02]

In your testing what toolchain are you using?

[commit-bot: I haz the power, 2014-06-11 13:56:15]

Change committed as 632a4546b085fea79f40212935e5ac6fa74612a2

[djordje, 2014-06-11 14:02:58]

On 2014/06/11 13:56:02, djsollen wrote:
> In your testing what toolchain are you using?

for android build NDK toolchain is used with script
./platform_tools/android/bin/android_ninja all -d mips
for testing on the MIPS linux platform native debian (wheezy) toolchain is used