Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 326903004: Properly handle bailout for dictionary style maps in the tracer. (Closed)

Created:
6 years, 6 months ago by herhut
Modified:
6 years, 6 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, floitsch
Visibility:
Public.

Description

Properly handle bailout for dictionary style maps in the tracer. BUG= http://dartbug.com/18836 R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=37254

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -26 lines) Patch
M sdk/lib/_internal/compiler/implementation/inferrer/map_tracer.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/inferrer/type_graph_nodes.dart View 6 chunks +17 lines, -11 lines 0 comments Download
M tests/compiler/dart2js/dictionary_types_test.dart View 5 chunks +39 lines, -15 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
herhut
There was a bug in the handling of MapTypeInformation that would allow erroneous type information ...
6 years, 6 months ago (2014-06-10 16:42:25 UTC) #1
Johnni Winther
lgtm
6 years, 6 months ago (2014-06-11 07:07:33 UTC) #2
herhut
6 years, 6 months ago (2014-06-12 07:49:20 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r37254 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698