Issue 326893003: Reset computed size of the <canvas> FontDescription when setting CRC2D.font

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 326893003: Reset computed size of the <canvas> FontDescription when setting CRC2D.font (Closed)

Created:
6 years, 6 months ago by fs

Modified:
6 years, 6 months ago

Reviewers:
dglazkov, Justin Novosad

CC:
aandrey+blink_chromium.org, blink-reviews, blink-reviews-html_chromium.org, Rik, dglazkov+blink

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Reset computed size of the <canvas> FontDescription when setting CRC2D.font Avoid inheriting the zoom-factor when setting the CanvasRenderingContext2D 'font' property to the same font as is computed for the <canvas> element. In this case the font descriptions would be considered the same, and hence the font size computed using the effective zoom of the page would be used. BUG=381989 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175950

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -3 lines)			Patch
	A	LayoutTests/fast/canvas/font-no-zoom.html	View		1 chunk	+19 lines, -0 lines	0 comments	Download
	M	Source/core/html/canvas/CanvasRenderingContext2D.cpp	View		1 chunk	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

@dglazkov: I hear you like font-related code, so if you could have a look before ...

6 years, 6 months ago (2014-06-10 16:26:41 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/326893003/1

6 years, 6 months ago (2014-06-11 08:59:41 UTC) #4

Message was sent while issue was closed.

Change committed as 175950

Expand Messages | Collapse Messages