Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 326823003: Remove lazy layout preference plumbing (Closed)

Created:
6 years, 6 months ago by Julien - ping for review
Modified:
6 years, 6 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, nasko+codewatch_chromium.org
Visibility:
Public.

Description

Remove lazy layout preference plumbing This is dead code as the Blink bits were removed in http://src.chromium.org/viewvc/blink?view=revision&revision=156126 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276417

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M content/browser/renderer_host/render_view_host_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/common/common_param_traits_macros.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/web_preferences.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/common/webpreferences.h View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/common/webpreferences.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
Julien - ping for review
6 years, 6 months ago (2014-06-10 02:27:51 UTC) #1
darin (slow to review)
OK, LGTM
6 years, 6 months ago (2014-06-10 04:52:38 UTC) #2
Julien - ping for review
The CQ bit was checked by jchaffraix@chromium.org
6 years, 6 months ago (2014-06-10 16:58:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/326823003/1
6 years, 6 months ago (2014-06-10 17:02:25 UTC) #4
Julien - ping for review
Adding some security folks for OWNERS approval, this is a trivial removal of an unused ...
6 years, 6 months ago (2014-06-10 20:20:07 UTC) #5
jln (very slow on Chromium)
security lgtm
6 years, 6 months ago (2014-06-10 20:25:19 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 01:11:58 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 07:14:57 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/builds/18805)
6 years, 6 months ago (2014-06-11 07:14:58 UTC) #9
Julien - ping for review
The CQ bit was checked by jchaffraix@chromium.org
6 years, 6 months ago (2014-06-11 15:56:56 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/326823003/1
6 years, 6 months ago (2014-06-11 16:00:11 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-06-11 16:02:41 UTC) #12
Message was sent while issue was closed.
Change committed as 276417

Powered by Google App Engine
This is Rietveld 408576698