Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 326823002: Linux: Take into account the weight/italic parameters when mapping fonts on Linux. (Closed)

Created:
6 years, 6 months ago by Lei Zhang
Modified:
6 years, 6 months ago
Reviewers:
jam
CC:
chromium-reviews
Visibility:
Public.

Description

Linux: Take into account the weight/italic parameters when mapping fonts on Linux. BUG=pdfium:7 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276161

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M pdf/pdfium/pdfium_engine.cc View 1 2 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Lei Zhang
|weight| and |italic| are currently ignored.
6 years, 6 months ago (2014-06-10 00:50:08 UTC) #1
jam
lgtm https://codereview.chromium.org/326823002/diff/1/pdf/pdfium/pdfium_engine.cc File pdf/pdfium/pdfium_engine.cc (right): https://codereview.chromium.org/326823002/diff/1/pdf/pdfium/pdfium_engine.cc#newcode225 pdf/pdfium/pdfium_engine.cc:225: normalized_weight = (normalized_weight / 100) - 1; nit: ...
6 years, 6 months ago (2014-06-10 05:47:07 UTC) #2
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 6 months ago (2014-06-10 07:10:11 UTC) #3
Lei Zhang
https://codereview.chromium.org/326823002/diff/1/pdf/pdfium/pdfium_engine.cc File pdf/pdfium/pdfium_engine.cc (right): https://codereview.chromium.org/326823002/diff/1/pdf/pdfium/pdfium_engine.cc#newcode225 pdf/pdfium/pdfium_engine.cc:225: normalized_weight = (normalized_weight / 100) - 1; On 2014/06/10 ...
6 years, 6 months ago (2014-06-10 07:10:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/326823002/20001
6 years, 6 months ago (2014-06-10 07:14:42 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg on tryserver.chromium ...
6 years, 6 months ago (2014-06-10 20:17:21 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-10 20:59:08 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/builds/150589)
6 years, 6 months ago (2014-06-10 20:59:09 UTC) #8
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 6 months ago (2014-06-10 21:08:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/326823002/20001
6 years, 6 months ago (2014-06-10 21:09:51 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-10 21:29:58 UTC) #11
Message was sent while issue was closed.
Change committed as 276161

Powered by Google App Engine
This is Rietveld 408576698