ash/wm/session_state_animator_impl_unittest.cc - Issue 326813004: Added quick lock mechanism while in Touchview

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ash/wm/session_state_animator_impl_unittest.cc

Issue 326813004: Added quick lock mechanism while in Touchview (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add docs for TestSessionStateAnimator::AnimationSequence. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // TODO(bruthig): Add some tests for the SessionStateAnimatorImpl.
	bruthig 2014/09/08 15:33:20 Tests for the integration of the SessionStateAnima Tests for the integration of the SessionStateAnimator & ui/compositor should be written at some point. I'm not sure if this needs to be tracked or if this is the best way to track that... Thoughts? Daniel Erat 2014/09/08 16:16:03 it'd be better to file a bug instead of checking i Show quoted text On 2014/09/08 15:33:20, bruthig wrote: > Tests for the integration of the SessionStateAnimator & ui/compositor should be > written at some point. I'm not sure if this needs to be tracked or if this is > the best way to track that... Thoughts? it'd be better to file a bug instead of checking in an empty file bruthig 2014/09/09 17:32:34 Ok, I will also add BUG=162645, it seems to alread Show quoted text On 2014/09/08 16:16:03, Daniel Erat wrote: > On 2014/09/08 15:33:20, bruthig wrote: > > Tests for the integration of the SessionStateAnimator & ui/compositor should > be > > written at some point. I'm not sure if this needs to be tracked or if this is > > the best way to track that... Thoughts? > > it'd be better to file a bug instead of checking in an empty file Ok, I will also add BUG=162645, it seems to already be tracking these missing tests. I will also add a comment after check-in to have record of the current state.
OLD	NEW