Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(653)

Issue 326753002: Fix use of LayoutStateDisabler for RenderView invalidation (Closed)

Created:
6 years, 6 months ago by leviw_travelin_and_unemployed
Modified:
6 years, 6 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, zoltan1
Visibility:
Public.

Description

Fix use of LayoutStateDisabler for RenderView invalidation In an attempt to optimize pushing and popping LayoutState, the entire optimization ended up being turned off. Fix the use of LayoutState for RenderView-relative renderers. BUG=381138 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175832

Patch Set 1 #

Patch Set 2 : Add test expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M LayoutTests/TestExpectations View 1 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderBox.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
dsinclair
lgtm
6 years, 6 months ago (2014-06-09 21:05:50 UTC) #1
Julien - ping for review
lgtm
6 years, 6 months ago (2014-06-09 21:09:01 UTC) #2
leviw_travelin_and_unemployed
The CQ bit was checked by leviw@chromium.org
6 years, 6 months ago (2014-06-09 21:18:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leviw@chromium.org/326753002/1
6 years, 6 months ago (2014-06-09 21:19:27 UTC) #4
leviw_travelin_and_unemployed
The CQ bit was checked by leviw@chromium.org
6 years, 6 months ago (2014-06-09 21:57:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leviw@chromium.org/326753002/20001
6 years, 6 months ago (2014-06-09 21:57:36 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-09 23:06:32 UTC) #7
Message was sent while issue was closed.
Change committed as 175832

Powered by Google App Engine
This is Rietveld 408576698