Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 326693002: Timeline: fix reset logic of TracingTimelineModel & co (Closed)

Created:
6 years, 6 months ago by caseq
Modified:
6 years, 6 months ago
Reviewers:
yurys, loislo
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

Timeline: fix reset logic of TracingTimelineModel & co The way we perform reset (i.e. clear records) was badly wrong in a couple of places: - we generally should only reset the objects that we own, so TimelineTracingView should have not tried to reset TracingModel; - TracingTimelineModel should reset before the record is started,not after. BUG=361045 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175810

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M Source/devtools/front_end/timeline/TimelinePanel.js View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineTracingView.js View 1 chunk +0 lines, -1 line 0 comments Download
M Source/devtools/front_end/timeline/TracingTimelineModel.js View 3 chunks +2 lines, -1 line 1 comment Download

Messages

Total messages: 8 (0 generated)
caseq
6 years, 6 months ago (2014-06-09 16:38:45 UTC) #1
loislo
lgtm
6 years, 6 months ago (2014-06-09 16:40:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caseq@chromium.org/326693002/1
6 years, 6 months ago (2014-06-09 16:41:44 UTC) #3
caseq
The CQ bit was unchecked by caseq@chromium.org
6 years, 6 months ago (2014-06-09 16:52:22 UTC) #4
caseq
The CQ bit was checked by caseq@chromium.org
6 years, 6 months ago (2014-06-09 16:53:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caseq@chromium.org/326693002/1
6 years, 6 months ago (2014-06-09 16:53:45 UTC) #6
commit-bot: I haz the power
Change committed as 175810
6 years, 6 months ago (2014-06-09 17:56:46 UTC) #7
yurys
6 years, 6 months ago (2014-06-10 07:04:27 UTC) #8
Message was sent while issue was closed.
https://codereview.chromium.org/326693002/diff/1/Source/devtools/front_end/ti...
File Source/devtools/front_end/timeline/TracingTimelineModel.js (right):

https://codereview.chromium.org/326693002/diff/1/Source/devtools/front_end/ti...
Source/devtools/front_end/timeline/TracingTimelineModel.js:104: this.reset();
This should go into _startRecordingWithCategories

Powered by Google App Engine
This is Rietveld 408576698