Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 32663003: Merge 159848 "Process decoded bytes when in stopped (but not det..." (Closed)

Created:
7 years, 2 months ago by jamesr
Modified:
7 years, 2 months ago
Reviewers:
jamesr
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org
Visibility:
Public.

Description

Merge 159848 "Process decoded bytes when in stopped (but not det..." > Process decoded bytes when in stopped (but not detached) state > > When a DecodedDataDocumentParser receives bytes it can choose whether to > pass those through to the underlying document's decoder or not. If the > parser is the detached state, there is no underlying document so it doesn't > make sense to process the bytes at all. r158300 patched > DecodedDataDocumentParser to not process bytes when in the stopped or detached > state but it turns out in some scenarios involving XSLT we receive bytes > in the stopped state. This relaxes the check from isStopped() to isDetached(). > > BUG=304965 > > Review URL: https://codereview.chromium.org/27394002 TBR=jamesr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160098

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
LayoutTests/http/tests/incremental/chunked-xsl-transformed-xml.pl View 0 chunks +-1 lines, --1 lines 0 comments Download
LayoutTests/http/tests/incremental/chunked-xsl-transformed-xml-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
LayoutTests/http/tests/incremental/resources/transform.xsl View 0 chunks +-1 lines, --1 lines 0 comments Download
Source/core/dom/DecodedDataDocumentParser.cpp View 2 chunks +8 lines, -2 lines 0 comments Download
Source/core/xml/parser/XMLDocumentParser.cpp View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
jamesr
7 years, 2 months ago (2013-10-21 17:08:21 UTC) #1
jamesr
7 years, 2 months ago (2013-10-21 17:08:43 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r160098.

Powered by Google App Engine
This is Rietveld 408576698