Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Unified Diff: Tools/Scripts/webkitpy/common/system/filesystem.py

Issue 32663002: Remove _unit_test_config hack, instead use FileSystem() in cpp.py & cpp_unittest.py (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Removed unneccessary import of codecs Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Tools/Scripts/webkitpy/style/checkers/cpp.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/Scripts/webkitpy/common/system/filesystem.py
diff --git a/Tools/Scripts/webkitpy/common/system/filesystem.py b/Tools/Scripts/webkitpy/common/system/filesystem.py
index 3786c6fed2222e6043fca5b316192878de2fe7d4..4ad3b1cfd37802a751f2ca724b14a0f8efc9f890 100644
--- a/Tools/Scripts/webkitpy/common/system/filesystem.py
+++ b/Tools/Scripts/webkitpy/common/system/filesystem.py
@@ -206,11 +206,11 @@ class FileSystem(object):
def open_text_file_for_writing(self, path):
return codecs.open(path, 'w', 'utf8')
- def read_text_file(self, path):
+ def read_text_file(self, path, errors='strict'):
Dirk Pranke 2013/10/22 19:17:03 Are you sure we need this? I.e., does test-webkitp
"""Return the contents of the file at the given path as a Unicode string.
The file is read assuming it is a UTF-8 encoded file with no BOM."""
- with codecs.open(path, 'r', 'utf8') as f:
+ with codecs.open(path, 'r', 'utf8', errors) as f:
return f.read()
def write_text_file(self, path, contents):
« no previous file with comments | « no previous file | Tools/Scripts/webkitpy/style/checkers/cpp.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698