Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issue 326623004: Undef FloatToFixed and FixedToFloat as well in SkConvolver to avoid confusion with OS X's maths lib… (Closed)

Created:
6 years, 6 months ago by gw280
Modified:
6 years, 6 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@header-guards
Visibility:
Public.

Description

Undef FloatToFixed and FixedToFloat as well in SkConvolver to avoid confusion with OS X's maths library BUG=skia: R=reed@google.com Committed: https://skia.googlesource.com/skia/+/ae6a059c68b535e8d2bd814d8d43361e2f8626df

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/core/SkConvolver.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
gw280
6 years, 6 months ago (2014-06-09 17:49:07 UTC) #1
reed1
lgtm
6 years, 6 months ago (2014-06-09 19:06:52 UTC) #2
gw280
The CQ bit was checked by george@mozilla.com
6 years, 6 months ago (2014-06-19 15:25:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/george@mozilla.com/326623004/1
6 years, 6 months ago (2014-06-19 15:25:28 UTC) #4
gw280
The CQ bit was unchecked by george@mozilla.com
6 years, 6 months ago (2014-06-19 15:26:53 UTC) #5
gw280
The CQ bit was checked by george@mozilla.com
6 years, 6 months ago (2014-06-19 15:26:54 UTC) #6
gw280
6 years, 6 months ago (2014-06-19 15:27:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/george@mozilla.com/326623004/1
6 years, 6 months ago (2014-06-19 15:27:02 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-20 13:33:03 UTC) #9
Message was sent while issue was closed.
Change committed as ae6a059c68b535e8d2bd814d8d43361e2f8626df

Powered by Google App Engine
This is Rietveld 408576698