Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 326603002: Revert 275652 "Remove unneeded JNI registrations." (Closed)

Created:
6 years, 6 months ago by Torne
Modified:
6 years, 6 months ago
Reviewers:
bulach, ostap
CC:
chromium-reviews, simonb (inactive)
Visibility:
Public.

Description

Revert 275652 "Remove unneeded JNI registrations." This has broken the Android WebView build by introducing an absolute path into the generated makefiles, rendering them nonportable. > Remove unneeded JNI registrations. > > Rather than registering all jni bindings at startup, only get references > to the class object for those files which require bindings. All others > are satisfied by exporting symbols which can be found automatically by > dalvik. > > This patch replaces excldue-libs=ALL with ld version script to strip unwanted > symbols: https://sourceware.org/binutils/docs-2.24/ld/VERSION.html#VERSION > > BUG= > > Review URL: https://codereview.chromium.org/147533004 TBR=sl.ostapenko@samsung.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275796

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -383 lines) Patch
M trunk/src/base/android/jni_generator/jni_generator.py View 9 chunks +10 lines, -72 lines 0 comments Download
M trunk/src/base/android/jni_generator/jni_generator_tests.py View 2 chunks +1 line, -40 lines 0 comments Download
D trunk/src/base/android/jni_generator/testNativeExportsOption.golden View 1 chunk +0 lines, -216 lines 0 comments Download
D trunk/src/build/android/android_exports.lst View 1 chunk +0 lines, -14 lines 0 comments Download
M trunk/src/build/common.gypi View 4 chunks +8 lines, -11 lines 0 comments Download
M trunk/src/build/jar_file_jni_generator.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/build/jni_generator.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/mojo/mojo_public.gypi View 2 chunks +0 lines, -20 lines 0 comments Download
M trunk/src/mojo/mojo_services.gypi View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Torne
6 years, 6 months ago (2014-06-09 11:29:35 UTC) #1
Torne
I can help you work out another solution to this problem but for now I ...
6 years, 6 months ago (2014-06-09 11:31:17 UTC) #2
Torne
The CQ bit was checked by torne@chromium.org
6 years, 6 months ago (2014-06-09 11:31:20 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-09 11:32:36 UTC) #4
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
6 years, 6 months ago (2014-06-09 11:32:37 UTC) #5
Torne
Committed patchset #1 manually as r275796 (presubmit successful).
6 years, 6 months ago (2014-06-09 11:33:40 UTC) #6
bulach
FYI, there were also some problems in our downstream bots. in there, we use the ...
6 years, 6 months ago (2014-06-09 13:15:35 UTC) #7
bulach
6 years, 6 months ago (2014-06-09 14:41:16 UTC) #8
Message was sent while issue was closed.
On 2014/06/09 13:15:35, bulach wrote:
> FYI, there were also some problems in our downstream bots.
> in there, we use the "crazy_linker", and for some reason it fails to find the
> method:
> java.lang.UnsatisfiedLinkError: Native method not found:
>
org.chromium.base.library_loader.LibraryLoader.nativeGetVersionNumber:()Ljava/lang/String;
> 
> I checked with readelf, it seems that the symbol is there:
>    419: 006e1e95    60 FUNC    GLOBAL DEFAULT    8
> Java_org_chromium_base_library_1loader_LibraryLoader_nativeGetVersionNumber
> 
> 
> I'm adding simon for helping with the crazy linker.
> (btw, we should probably enable it in chromeshell?)

BTW, here's a bug with far more details :)
https://code.google.com/p/chromium/issues/detail?id=382481

Powered by Google App Engine
This is Rietveld 408576698