Issue 3266013: Add unit test for ReplaceStringPlaceholders

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3266013: Add unit test for ReplaceStringPlaceholders (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 9 months ago by Aaron Boodman

Modified:
3 years, 11 months ago

Reviewers:
eroman

CC:
chromium-reviews, Paweł Hajdan Jr., jshin+watch_chromium.org, brettw-cc_chromium.org

Base URL:
git://codf21.jail/chromium.git

Visibility:
Public.

Description

Add unit test for functionality added to ReplaceStringPlaceholders in r57966. TEST=base_unittests --gtest_filter=StringUtilTest.ReplaceStringPlaceholders* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58047

Patch Set 1 #

Total comments: 1

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -2 lines)			Patch
	M	base/string_util.h	View		1 chunk	+3 lines, -2 lines	0 comments	Download
	M	base/string_util_unittest.cc	View		1 chunk	+9 lines, -0 lines	1 comment	Download

Trybot results: mac linux win

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

eroman

4 years, 9 months ago (2010-08-31 06:37:06 UTC) #1

lgtm

http://codereview.chromium.org/3266013/diff/1/3
File base/string_util_unittest.cc (right):

http://codereview.chromium.org/3266013/diff/1/3#newcode1021
base/string_util_unittest.cc:1021: EXPECT_EQ(ReplaceStringPlaceholders("$$1 $$$2
$$$$3", subst, NULL),
nit: EXPECT_EQ(expected, actual).

Expand Messages | Collapse Messages