Issue 3266012: Fetch info about the state of navigation in a tab

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3266012: Fetch info about the state of navigation in a tab (Closed)

Created:
10 years, 3 months ago by Nirnimesh

Modified:
9 years, 7 months ago

Reviewers:
John Grabowski

CC:
chromium-reviews, ben+cc_chromium.org, Paweł Hajdan Jr.

Visibility:
Public.

Description

Fetch info about the state of navigation in a tab This includes info about: - ssl status: allows for automation of ssl tests - page type - favicon TEST=ssl.py Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58015

Patch Set 1 #

Patch Set 2 : add ssl.py #

Total comments: 3

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+133 lines, -0 lines)			Patch
M	chrome/browser/automation/automation_provider.h	View	1 chunk	+7 lines, -0 lines	1 comment	Download
M	chrome/browser/automation/automation_provider.cc	View	3 chunks	+53 lines, -0 lines	1 comment	Download
	chrome/test/functional/ssl.py	View	1 chunk	+39 lines, -0 lines	1 comment	Download
M	chrome/test/pyautolib/pyauto.py	View	1 chunk	+34 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

John Grabowski

10 years, 3 months ago (2010-08-31 05:51:16 UTC) #2

LGTM

http://codereview.chromium.org/3266012/diff/2001/1004
File chrome/browser/automation/automation_provider.cc (right):

http://codereview.chromium.org/3266012/diff/2001/1004#newcode2132
chrome/browser/automation/automation_provider.cc:2132: std::map<std::string,
JsonHandler> handler_map;
We're starting to get a lot of these.  Perhaps (not in this CL) we can move
construction of this map to a setup routine called by the AutomationProvider? 
(Perhaps in a different CL)

http://codereview.chromium.org/3266012/diff/2001/1005
File chrome/browser/automation/automation_provider.h (right):

http://codereview.chromium.org/3266012/diff/2001/1005#newcode251
chrome/browser/automation/automation_provider.h:251: DictionaryValue* args,
indenting?  Need --> 1 more for 2nd 2 lines

http://codereview.chromium.org/3266012/diff/2001/1006
File chrome/test/functional/ssl.py (right):

http://codereview.chromium.org/3266012/diff/2001/1006#newcode34
chrome/test/functional/ssl.py:34:
self.assertFalse(ssl["displayed_insecure_content"])
you switched from ' to " in the middle of this function.  Stick with '

Expand Messages | Collapse Messages