Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 326583002: use setInfo instead of (deprecated) setConfig (Closed)

Created:
6 years, 6 months ago by reed2
Modified:
6 years, 6 months ago
Reviewers:
danakj, sky, reed1
CC:
chromium-reviews, scroggo
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

use setInfo instead of (deprecated) setConfig needed to unblock skia roll TBR= mac_chromium_rel is taking forever, and its run is clean w.r.t. this CL NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275825

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -10 lines) Patch
M ui/gfx/icon_util_unittest.cc View 4 chunks +8 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
reed2
6 years, 6 months ago (2014-06-09 09:09:14 UTC) #1
reed2
6 years, 6 months ago (2014-06-09 09:11:21 UTC) #2
reed2
The CQ bit was checked by reed@chromium.org
6 years, 6 months ago (2014-06-09 10:43:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@chromium.org/326583002/1
6 years, 6 months ago (2014-06-09 10:44:22 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-09 10:44:22 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 6 months ago (2014-06-09 10:44:23 UTC) #6
reed2
The CQ bit was checked by reed@chromium.org
6 years, 6 months ago (2014-06-09 10:50:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@chromium.org/326583002/1
6 years, 6 months ago (2014-06-09 10:51:33 UTC) #8
reed1
The CQ bit was unchecked by reed@google.com
6 years, 6 months ago (2014-06-09 16:57:01 UTC) #9
reed1
The CQ bit was checked by reed@google.com
6 years, 6 months ago (2014-06-09 16:57:11 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@chromium.org/326583002/1
6 years, 6 months ago (2014-06-09 16:58:04 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-06-09 17:11:19 UTC) #12
Message was sent while issue was closed.
Change committed as 275825

Powered by Google App Engine
This is Rietveld 408576698