Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 326573002: Remove public web methods using toV8 with empty context. (Closed)

Created:
6 years, 6 months ago by tasak
Modified:
6 years, 6 months ago
CC:
abarth-chromium, blink-reviews, dglazkov+blink, jamesr, kinuko+fileapi, nhiroki, tzik
Visibility:
Public.

Description

Remove public web methods using toV8 with empty context. The following chromium commits fixed chromium code to use new public web methods which take creation context and isolate: WebBlob - https://src.chromium.org/viewvc/chrome?view=rev&revision=275420 WebDOMError - https://src.chromium.org/viewvc/chrome?view=rev&revision=275396 WebDOMFileSystem: - https://src.chromium.org/viewvc/chrome?view=rev&revision=275291 BUG=369451 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175777

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -40 lines) Patch
M Source/web/WebBlob.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/web/WebDOMError.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M Source/web/WebDOMFileSystem.cpp View 2 chunks +0 lines, -18 lines 0 comments Download
M public/web/WebBlob.h View 1 chunk +0 lines, -2 lines 0 comments Download
M public/web/WebDOMError.h View 1 chunk +0 lines, -4 lines 0 comments Download
M public/web/WebDOMFileSystem.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tasak
Would you review this CL?
6 years, 6 months ago (2014-06-09 04:54:21 UTC) #1
haraken
LGTM.
6 years, 6 months ago (2014-06-09 04:55:10 UTC) #2
abarth-chromium
lgtm
6 years, 6 months ago (2014-06-09 05:02:31 UTC) #3
tasak
Thank you.
6 years, 6 months ago (2014-06-09 06:37:16 UTC) #4
tasak
The CQ bit was checked by tasak@google.com
6 years, 6 months ago (2014-06-09 06:37:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tasak@google.com/326573002/1
6 years, 6 months ago (2014-06-09 06:37:50 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-09 06:50:27 UTC) #7
Message was sent while issue was closed.
Change committed as 175777

Powered by Google App Engine
This is Rietveld 408576698