Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 326523002: Cleanup: Get rid of make_isize() function from gm.h. (Closed)

Created:
6 years, 6 months ago by tfarina
Modified:
6 years, 6 months ago
Reviewers:
robertphillips, reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Cleanup: Get rid of make_isize() function from gm.h. This helper function is not necessary. The same thing can be achieved by using SkISize::Make() provided by SkTSize API. BUG=skia:2645 TEST=make dm && out/Debug/dm R=robertphillips@google.com Committed: https://skia.googlesource.com/skia/+/f539318f0d3dba743ec1886d5d9df0fb1be628a1

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -113 lines) Patch
M gm/aarectmodes.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/androidfallback.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/arcofzorro.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/beziereffects.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M gm/bicubicfilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/bigblurs.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/bigmatrix.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/bitmapcopy.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/bitmapfilters.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/bitmapmatrix.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/bitmapscroll.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/blurs.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/circles.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/cmykjpeg.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/coloremoji.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/colormatrix.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/complexclip.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/complexclip2.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M gm/convexpaths.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/convexpolyclip.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/convexpolyeffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/copyTo4444.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M gm/dashing.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M gm/degeneratesegments.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/deviceproperties.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/displacement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/distantclip.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/drawbitmaprect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/emptypath.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/etc1bitmap.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M gm/extractbitmap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/factory.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M gm/filltypes.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/filltypespersp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/fontscaler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/gammatext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/getpostextpath.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/gm.h View 1 1 chunk +0 lines, -6 lines 0 comments Download
M gm/gradientDirtyLaundry.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/gradients_no_texture.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/gradtext.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M gm/hairlines.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/hairmodes.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/imagealphathreshold.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/imageblur.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/imageblurtiled.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/imagefiltersclipped.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/imagefiltersscaled.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/imagemagnifier.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/imageresizetiled.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/internal_links.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/inversepaths.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/lcdtext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/linepaths.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/matrixconvolution.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/matriximagefilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/mixedxfermodes.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/modecolorfilters.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/morphology.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/nested.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/ninepatchstretch.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/offsetimagefilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/ovals.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/patheffects.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/pathopsinverse.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/pathopsskpclip.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/pathreverse.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/points.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/quadpaths.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/rects.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/resizeimagefilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/roundrects.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/rrects.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/samplerstress.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/selftest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/shaderbounds.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/shadertext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/shadertext2.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/shadertext3.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/shadows.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/simpleaaclip.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/skbug1719.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/strokefill.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/strokerects.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/texdata.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/texturedomaineffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/thinrects.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/thinstrokedrects.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/tileimagefilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/tinybitmap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/twopointradial.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/verttext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/verttext2.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/xfermodeimagefilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/xfermodes.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/xfermodes2.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/xfermodes3.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
tfarina
mechanical change. rubber stamp? Thanks,
6 years, 6 months ago (2014-06-08 22:25:58 UTC) #1
robertphillips
lgtm
6 years, 6 months ago (2014-06-08 23:13:39 UTC) #2
reed1
woot!
6 years, 6 months ago (2014-06-09 12:26:33 UTC) #3
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 6 months ago (2014-06-10 05:50:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/tfarina@chromium.org/326523002/20001
6 years, 6 months ago (2014-06-10 05:52:10 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-10 06:59:08 UTC) #6
Message was sent while issue was closed. 
Change committed as f539318f0d3dba743ec1886d5d9df0fb1be628a1

Powered by Google App Engine
This is Rietveld 408576698