Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 326433002: Use ScopedPtrHashMap for CDMs in BrowserCdmManager. (Closed)

Created:
6 years, 6 months ago by xhwang
Modified:
6 years, 6 months ago
Reviewers:
ddorwin
CC:
chromium-reviews, feature-media-reviews_chromium.org, jam, darin-cc_chromium.org
Visibility:
Public.

Description

Use ScopedPtrHashMap for CDMs in BrowserCdmManager. This simplifies a lot of code. BUG=315312 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276410

Patch Set 1 #

Patch Set 2 : remove obsolete comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -14 lines) Patch
M content/browser/media/cdm/browser_cdm_manager.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/media/cdm/browser_cdm_manager.cc View 5 chunks +5 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
xhwang
A super small CL :) PTAL
6 years, 6 months ago (2014-06-06 21:16:19 UTC) #1
ddorwin
lgtm
6 years, 6 months ago (2014-06-06 21:21:45 UTC) #2
xhwang
The CQ bit was checked by xhwang@chromium.org
6 years, 6 months ago (2014-06-10 23:41:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/326433002/10001
6 years, 6 months ago (2014-06-10 23:45:04 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 11:51:28 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-11 15:38:02 UTC) #6
Message was sent while issue was closed.
Change committed as 276410

Powered by Google App Engine
This is Rietveld 408576698