Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Side by Side Diff: src/hydrogen.cc

Issue 32643004: Add a soft-deopt in keyed element access when current IC is pre-monomorphic and no type feedback wa… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ast.cc ('k') | src/ic.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 5767 matching lines...) Expand 10 before | Expand all | Expand 10 after
5778 BuildCheckHeapObject(obj); 5778 BuildCheckHeapObject(obj);
5779 instr = BuildMonomorphicElementAccess( 5779 instr = BuildMonomorphicElementAccess(
5780 obj, key, val, NULL, map, is_store, expr->GetStoreMode()); 5780 obj, key, val, NULL, map, is_store, expr->GetStoreMode());
5781 } 5781 }
5782 } else if (types != NULL && !types->is_empty()) { 5782 } else if (types != NULL && !types->is_empty()) {
5783 return HandlePolymorphicElementAccess( 5783 return HandlePolymorphicElementAccess(
5784 obj, key, val, types, position, is_store, 5784 obj, key, val, types, position, is_store,
5785 expr->GetStoreMode(), has_side_effects); 5785 expr->GetStoreMode(), has_side_effects);
5786 } else { 5786 } else {
5787 if (is_store) { 5787 if (is_store) {
5788 if (expr->IsAssignment() && expr->AsAssignment()->IsUninitialized()) { 5788 if (expr->IsAssignment() &&
5789 expr->AsAssignment()->HasNoTypeInformation()) {
5789 Add<HDeoptimize>("Insufficient type feedback for keyed store", 5790 Add<HDeoptimize>("Insufficient type feedback for keyed store",
5790 Deoptimizer::SOFT); 5791 Deoptimizer::SOFT);
5791 } 5792 }
5792 instr = BuildStoreKeyedGeneric(obj, key, val); 5793 instr = BuildStoreKeyedGeneric(obj, key, val);
5793 } else { 5794 } else {
5794 if (expr->AsProperty()->IsUninitialized()) { 5795 if (expr->AsProperty()->HasNoTypeInformation()) {
5795 Add<HDeoptimize>("Insufficient type feedback for keyed load", 5796 Add<HDeoptimize>("Insufficient type feedback for keyed load",
5796 Deoptimizer::SOFT); 5797 Deoptimizer::SOFT);
5797 } 5798 }
5798 instr = BuildLoadKeyedGeneric(obj, key); 5799 instr = BuildLoadKeyedGeneric(obj, key);
5799 } 5800 }
5800 AddInstruction(instr); 5801 AddInstruction(instr);
5801 } 5802 }
5802 if (position != RelocInfo::kNoPosition) instr->set_position(position); 5803 if (position != RelocInfo::kNoPosition) instr->set_position(position);
5803 *has_side_effects = instr->HasObservableSideEffects(); 5804 *has_side_effects = instr->HasObservableSideEffects();
5804 return instr; 5805 return instr;
(...skipping 4047 matching lines...) Expand 10 before | Expand all | Expand 10 after
9852 if (ShouldProduceTraceOutput()) { 9853 if (ShouldProduceTraceOutput()) {
9853 isolate()->GetHTracer()->TraceHydrogen(name(), graph_); 9854 isolate()->GetHTracer()->TraceHydrogen(name(), graph_);
9854 } 9855 }
9855 9856
9856 #ifdef DEBUG 9857 #ifdef DEBUG
9857 graph_->Verify(false); // No full verify. 9858 graph_->Verify(false); // No full verify.
9858 #endif 9859 #endif
9859 } 9860 }
9860 9861
9861 } } // namespace v8::internal 9862 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/ast.cc ('k') | src/ic.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698