Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(906)

Issue 326413003: SkNEW as default Create() for SkLazyPtr macros. (Closed)

Created:
6 years, 6 months ago by mtklein_C
Modified:
6 years, 6 months ago
Reviewers:
hal.canary, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

SkNEW as default Create() for SkLazyPtr macros. BUG=skia: Committed: https://skia.googlesource.com/skia/+/6059f16fd98421ef1add03f708f3fd2c21cfc4f5

Patch Set 1 #

Patch Set 2 : port SkFCI_direct #

Patch Set 3 : update exemption #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -22 lines) Patch
M src/core/SkLazyPtr.h View 1 2 6 chunks +22 lines, -17 lines 0 comments Download
M src/ports/SkFontConfigInterface_direct.cpp View 1 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
mtklein
6 years, 6 months ago (2014-06-11 16:54:04 UTC) #1
hal.canary
lgtm
6 years, 6 months ago (2014-06-11 17:11:03 UTC) #2
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 6 months ago (2014-06-11 18:20:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/326413003/20001
6 years, 6 months ago (2014-06-11 18:20:57 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug-Trybot on tryserver.skia ...
6 years, 6 months ago (2014-06-11 18:32:57 UTC) #5
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 6 months ago (2014-06-11 18:42:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/326413003/40001
6 years, 6 months ago (2014-06-11 18:42:31 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-11 18:57:48 UTC) #8
Message was sent while issue was closed.
Change committed as 6059f16fd98421ef1add03f708f3fd2c21cfc4f5

Powered by Google App Engine
This is Rietveld 408576698