Issue 326403006: Enables PacketGenerator's use of PacketCreator's FEC primitives.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 326403006: Enables PacketGenerator's use of PacketCreator's FEC primitives. (Closed)

Created:
6 years, 6 months ago by ramant (doing other things)

Modified:
6 years, 6 months ago

Reviewers:
Jana, Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Enables PacketGenerator's use of PacketCreator's FEC primitives. Adds methods in PacketGenerator that enable use of the PacketCreator's FEC primitives, and adds tests for these methods. Merge internal change: 68558082 R=jri@chromium.org, rch@chromium.org

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+473 lines, -61 lines)			Patch
M	net/net.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	net/quic/quic_connection_test.cc	View	7 chunks	+13 lines, -10 lines	0 comments	Download
M	net/quic/quic_packet_creator.h	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	net/quic/quic_packet_creator.cc	View	2 chunks	+6 lines, -1 line	0 comments	Download
M	net/quic/quic_packet_creator_test.cc	View	5 chunks	+12 lines, -4 lines	0 comments	Download
M	net/quic/quic_packet_generator.h	View	3 chunks	+31 lines, -0 lines	0 comments	Download
M	net/quic/quic_packet_generator.cc	View	4 chunks	+59 lines, -26 lines	0 comments	Download
M	net/quic/quic_packet_generator_test.cc	View	7 chunks	+262 lines, -3 lines	0 comments	Download
M	net/quic/test_tools/quic_connection_peer.h	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	net/quic/test_tools/quic_connection_peer.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	net/quic/test_tools/quic_packet_creator_peer.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	net/quic/test_tools/quic_packet_creator_peer.cc	View	1 chunk	+0 lines, -8 lines	0 comments	Download
A	net/quic/test_tools/quic_packet_generator_peer.h	View	1 chunk	+36 lines, -0 lines	0 comments	Download
A	net/quic/test_tools/quic_packet_generator_peer.cc	View	1 chunk	+34 lines, -0 lines	0 comments	Download
M	net/tools/quic/end_to_end_test.cc	View	3 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages