Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 326403002: Merge ViewHostMsg_TextInputTypeChanged and ViewHostMsg_TextInputStateChanged into one. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixed. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/npapi/webplugin_delegate_proxy.cc ('k') | content/renderer/render_view_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 438fe80673a6cba2a85a9221211ed6a6ebd6d2b5..2946ab7b900f7aa584211a0ff4e22f2546668ec1 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -512,7 +512,8 @@ void RenderFrameImpl::PepperTextInputTypeChanged(
if (instance != render_view_->focused_pepper_plugin())
return;
- GetRenderWidget()->UpdateTextInputType();
+ GetRenderWidget()->UpdateTextInputState(
+ RenderWidget::NO_SHOW_IME, RenderWidget::FROM_NON_IME);
if (render_view_->renderer_accessibility())
render_view_->renderer_accessibility()->FocusedNodeChanged(WebNode());
}
@@ -2202,17 +2203,14 @@ void RenderFrameImpl::didChangeSelection(bool is_empty_selection) {
if (is_empty_selection)
selection_text_.clear();
- // UpdateTextInputType should be called before SyncSelectionIfRequired.
- // UpdateTextInputType may send TextInputTypeChanged to notify the focus
+ // UpdateTextInputState should be called before SyncSelectionIfRequired.
+ // UpdateTextInputState may send TextInputStateChanged to notify the focus
// was changed, and SyncSelectionIfRequired may send SelectionChanged
// to notify the selection was changed. Focus change should be notified
// before selection change.
- GetRenderWidget()->UpdateTextInputType();
+ GetRenderWidget()->UpdateTextInputState(
+ RenderWidget::NO_SHOW_IME, RenderWidget::FROM_NON_IME);
SyncSelectionIfRequired();
-#if defined(OS_ANDROID)
- GetRenderWidget()->UpdateTextInputState(RenderWidget::NO_SHOW_IME,
- RenderWidget::FROM_NON_IME);
-#endif
}
blink::WebColorChooser* RenderFrameImpl::createColorChooser(
« no previous file with comments | « content/renderer/npapi/webplugin_delegate_proxy.cc ('k') | content/renderer/render_view_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698