Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 326393004: Check the path in the zip archive not the path to the file. (Closed)

Created:
6 years, 6 months ago by mkosiba (inactive)
Modified:
6 years, 6 months ago
Reviewers:
cjhopman
CC:
chromium-reviews, klundberg+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Check the path in the zip archive not the path to the file. This check was breaking the Android checked builds. BUG=internal b/15621260 TBR=cjhopman@chromium.org // Android-only build-only change, builds fine on Android trybots. NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277746

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/android/gyp/util/build_utils.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
mkosiba (inactive)
carrying over LGTM from https://codereview.chromium.org/255613003/
6 years, 6 months ago (2014-06-17 11:18:22 UTC) #1
mkosiba (inactive)
The CQ bit was checked by mkosiba@chromium.org
6 years, 6 months ago (2014-06-17 12:58:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkosiba@chromium.org/326393004/1
6 years, 6 months ago (2014-06-17 12:59:38 UTC) #3
commit-bot: I haz the power
6 years, 6 months ago (2014-06-17 13:11:29 UTC) #4
Message was sent while issue was closed.
Change committed as 277746

Powered by Google App Engine
This is Rietveld 408576698