Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1294)

Unified Diff: Source/core/rendering/HitTestResult.h

Issue 326393003: Oilpan: Change Persistent<> data members to Member<> in HitTestResult. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Follow review comments Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/HitTestResult.h
diff --git a/Source/core/rendering/HitTestResult.h b/Source/core/rendering/HitTestResult.h
index 4db557a1fc198d18aa1c66dee9591edc88f071dd..7be5962a26d864efcd506eda243fbac5b87e3fa6 100644
--- a/Source/core/rendering/HitTestResult.h
+++ b/Source/core/rendering/HitTestResult.h
@@ -46,6 +46,7 @@ class RenderObject;
class Scrollbar;
class HitTestResult {
zerny-chromium 2014/06/18 05:33:05 Nit: FINAL
+ DISALLOW_ALLOCATION();
public:
typedef WillBeHeapListHashSet<RefPtrWillBeMember<Node> > NodeSet;
@@ -57,6 +58,7 @@ public:
HitTestResult(const HitTestResult&);
~HitTestResult();
HitTestResult& operator=(const HitTestResult&);
+ void trace(Visitor*);
Node* innerNode() const { return m_innerNode.get(); }
Node* innerPossiblyPseudoNode() const { return m_innerPossiblyPseudoNode.get(); }
@@ -130,18 +132,18 @@ private:
HitTestLocation m_hitTestLocation;
- RefPtrWillBePersistent<Node> m_innerNode;
- RefPtrWillBePersistent<Node> m_innerPossiblyPseudoNode;
- RefPtrWillBePersistent<Node> m_innerNonSharedNode;
+ RefPtrWillBeMember<Node> m_innerNode;
+ RefPtrWillBeMember<Node> m_innerPossiblyPseudoNode;
+ RefPtrWillBeMember<Node> m_innerNonSharedNode;
LayoutPoint m_pointInInnerNodeFrame; // The hit-tested point in innerNode frame coordinates.
LayoutPoint m_localPoint; // A point in the local coordinate space of m_innerNonSharedNode's renderer. Allows us to efficiently
// determine where inside the renderer we hit on subsequent operations.
- RefPtrWillBePersistent<Element> m_innerURLElement;
+ RefPtrWillBeMember<Element> m_innerURLElement;
RefPtr<Scrollbar> m_scrollbar;
bool m_isOverWidget; // Returns true if we are over a widget (and not in the border/padding area of a RenderWidget for example).
bool m_isFirstLetter;
- mutable OwnPtrWillBePersistent<NodeSet> m_rectBasedTestResult;
+ mutable OwnPtrWillBeMember<NodeSet> m_rectBasedTestResult;
};
} // namespace WebCore

Powered by Google App Engine
This is Rietveld 408576698