Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 326383004: Revert of NaCl: Update revision in DEPS, r13309 -> r13318 (Closed)

Created:
6 years, 6 months ago by please use gerrit instead
Modified:
6 years, 6 months ago
Reviewers:
Mark Seaborn, bradn
CC:
chromium-reviews, David Yen, JF, Roland McGrath, native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Revert of NaCl: Update revision in DEPS, r13309 -> r13318 (https://codereview.chromium.org/324353002/) Reason for revert: The change appears to have broken http://build.chromium.org/p/chromium.chrome/buildstatus?builder=Google%20Chrome%20ChromeOS&number=68537. Original issue's description: > NaCl: Update revision in DEPS, r13309 -> r13318 > > This pulls in the following Native Client changes: > > r13310: (dyen) Commands for toolchain_build are now filtered before invoking anything. > r13311: (dyen) Fix for needing to push to ssh URL for toolchain_build sources. > r13312: (mcgrathr) Disable seccomp-bpf tests under ASan > r13313: (mcgrathr) Disable LSan (leak detection) in ASan tests > r13314: (mseaborn) Enable the -Wstrict-prototypes warning for untrusted code in the Gyp build > r13315: (dyen) Python logging now organized to use loggers instead of global variables. > r13316: (jfb) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS > r13317: (jfb) Update revision for PNaCl r13281->r13311 > r13318: (jfb) Update revision for PNaCl r13311->r13316 > > BUG=none > TEST=browser_tests and nacl_integration > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276475 TBR=bradnelson@google.com,mseaborn@chromium.org NOTREECHECKS=true NOTRY=true BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276479

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
please use gerrit instead
Created Revert of NaCl: Update revision in DEPS, r13309 -> r13318
6 years, 6 months ago (2014-06-11 19:57:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rouslan@chromium.org/326383004/1
6 years, 6 months ago (2014-06-11 20:00:43 UTC) #2
commit-bot: I haz the power
Change committed as 276479
6 years, 6 months ago (2014-06-11 20:04:32 UTC) #3
Mark Seaborn
6 years, 6 months ago (2014-06-13 00:39:50 UTC) #4
Message was sent while issue was closed.
LGTM

Sorry about that breakage.  build_nexe.py has known problems with correctness of
incremental builds, so I was overly optimistic in expecting that a try job would
be good enough to test my change. :-/

Powered by Google App Engine
This is Rietveld 408576698