Flag covering Rollback removed.

Flag covering Rollback removed.

BUG=368860
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277725

[Nikita (slow), 2014-06-11 14:08:56]

Please introduce kill switch though:

--disable-rollback-option

and a single method that checks it.

[merkulova, 2014-06-11 15:03:43]

Flag added.

[Nikita (slow), 2014-06-16 15:34:47]

Are you referencing the right bug? That one is marked as fixed.

[merkulova, 2014-06-16 15:45:13]

On 2014/06/16 15:34:47, Nikita Kostylev wrote:
> Are you referencing the right bug? That one is marked as fixed.

Oops, thought the CL has landed. Sorry

[Nikita (slow), 2014-06-16 15:47:16]

lgtm

nit: May as well add checks for  switches::kDisableRollbackOption in tests.

This one is good to go, lgtm & cq

[commit-bot: I haz the power, 2014-06-16 15:48:04]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/merkulova@chromium.org/326373002/20001

[commit-bot: I haz the power, 2014-06-16 19:39:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-16 19:39:35]

Try jobs failed on following builders:
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/17336)

[merkulova, 2014-06-16 21:10:12]

The CQ bit was checked by merkulova@chromium.org

[commit-bot: I haz the power, 2014-06-16 21:13:01]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/merkulova@chromium.org/326373002/20001

[commit-bot: I haz the power, 2014-06-16 22:54:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-16 22:54:57]

Try jobs failed on following builders:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/8...)
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/19...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/17447)

[Nikita (slow), 2014-06-17 06:23:31]

needs rebase

[merkulova, 2014-06-17 07:38:59]

The CQ bit was checked by merkulova@chromium.org

[commit-bot: I haz the power, 2014-06-17 07:40:01]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/merkulova@chromium.org/326373002/40001

[commit-bot: I haz the power, 2014-06-17 11:23:37]

Change committed as 277725

[Nikita (slow), 2014-06-23 16:27:02]

A revert of this CL has been created in
https://codereview.chromium.org/344963003/ by nkostylev@chromium.org.

The reason for reverting is: This feature is postponed to M38..