LayoutTests/editing/undo/undo-set-selection-crash.html - Issue 326323003: Fix a crash caused by invalid selection set by Undo command. - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(232)

My Issues | Starred Open | Closed | All

Unified Diff: LayoutTests/editing/undo/undo-set-selection-crash.html

Issue 326323003: Fix a crash caused by invalid selection set by Undo command. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« LayoutTests/editing/undo/resources/undo-set-selection-crash-iframe.html ('K') | « LayoutTests/editing/undo/resources/undo-set-selection-crash-iframe.html ('k') | LayoutTests/editing/undo/undo-set-selection-crash-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/editing/undo/undo-set-selection-crash.html

diff --git a/LayoutTests/editing/execCommand/format-block-crash.html b/LayoutTests/editing/undo/undo-set-selection-crash.html

similarity index 74%

copy from LayoutTests/editing/execCommand/format-block-crash.html

copy to LayoutTests/editing/undo/undo-set-selection-crash.html

index 881a6d825320d1a326b41802abcf516e9c6860b9..975f84f4e94c1cc37e108503dd5fbdef54bc11d1 100644

--- a/LayoutTests/editing/execCommand/format-block-crash.html

+++ b/LayoutTests/editing/undo/undo-set-selection-crash.html

@@ -1,19 +1,18 @@

<!DOCTYPE html>

<html>

<head>

-<title>FormatBlock crash</title>

<script src="../../resources/js-test.js"></script>

</head>

<body>

<script>

-description('Should not crash if we load a test case from crbug.com/345005.');

+description('Undo command should not make a selection anchored in another document.');

window.jsTestIsAsync = true;

window.addEventListener('message', didReceiveMessage, false);

var iframe = document.createElement('iframe');

-iframe.src = 'resources/format-block-crash-iframe.html';

+iframe.src = 'resources/undo-set-selection-crash-iframe.html';

document.body.appendChild(iframe);

function didReceiveMessage(event)

« LayoutTests/editing/undo/resources/undo-set-selection-crash-iframe.html ('K') | « LayoutTests/editing/undo/resources/undo-set-selection-crash-iframe.html ('k') | LayoutTests/editing/undo/undo-set-selection-crash-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine

This is Rietveld 408576698