LayoutTests/editing/undo/resources/undo-set-selection-crash-iframe.html - Issue 326323003: Fix a crash caused by invalid selection set by Undo command.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/editing/undo/resources/undo-set-selection-crash-iframe.html

Issue 326323003: Fix a crash caused by invalid selection set by Undo command. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 <html>
	yosin_UTC9 2014/06/11 09:02:51 nit: Could you add <!DOCTYPE html> to make Blink i nit: Could you add <!DOCTYPE html> to make Blink in strict mode? Most of real world HTML document uses strict mode. Yuta Kitamura 2014/06/12 06:23:25 I thought that was impossible because the original Show quoted text On 2014/06/11 09:02:51, yosi wrote: > nit: Could you add <!DOCTYPE html> to make Blink in strict mode? Most of real > world HTML document uses strict mode. I thought that was impossible because the original clusterfuzz test case selected the entire document and a DOCTYPE node caused Range.extractContents() to fail. But in my version the selection is limited within div, so it's entirely possible to do that. Better yet, I've noticed I don't have to use the iframe, since execCommands do not destroy the js-test messages. Fixed by merging the iframe with the main test file.
	2 <body>

	3 <div contentEditable="true"><select></div>

	4 <script type="text/javascript">

	5 var div = document.getElementsByTagName('div')[0];

	6

	7 var selection = window.getSelection();

	8

	9 div.focus();

	10 document.execCommand('SelectAll');

	11 document.execCommand('Indent');

	12 document.execCommand('Outdent');

	13

	14 var anotherDocument = document.implementation.createHTMLDocument('');

	15 anotherDocument.body.appendChild(selection.getRangeAt(0).extractContents());

	16

	17 div.contentEditable = false;

	18

	19 document.execCommand('Undo');

	20 document.execCommand('FindString', false, 'x');

	21

	22 window.setTimeout(notifyFinish, 0);
	yosin_UTC9 2014/06/11 09:02:51 Q: Is it better to use jsTestIsAsync and finishJST Q: Is it better to use jsTestIsAsync and finishJSTest()? Yuta Kitamura 2014/06/12 06:23:25 Fixed by removing iframe file. Show quoted text On 2014/06/11 09:02:51, yosi wrote: > Q: Is it better to use jsTestIsAsync and finishJSTest()? Fixed by removing iframe file.
	23

	24 function notifyFinish()

	25 {

	26 window.parent.postMessage('FINISH', '*');

	27 }

	28
	yosin_UTC9 2014/06/11 09:02:51 nit: Please remove an extra blank line. nit: Please remove an extra blank line. Yuta Kitamura 2014/06/12 06:23:25 Fixed by removing iframe file. Show quoted text On 2014/06/11 09:02:51, yosi wrote: > nit: Please remove an extra blank line. Fixed by removing iframe file.
	29 </script>

	30 </body>

	31 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/editing/undo/undo-set-selection-crash.html » ('j') | no next file with comments »