Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Issue 326323002: Don't use LOG() from platform. (Closed)

Created:
6 years, 6 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 6 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Don't use LOG() from platform. All places that use OS::Allocate either CHECK() that the result is non-NULL, or use a reasonable fallback if they can't mmap memory. BUG=none R=mstarzinger@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=21810

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -35 lines) Patch
M src/platform-cygwin.cc View 1 chunk +1 line, -4 lines 0 comments Download
M src/platform-freebsd.cc View 1 chunk +1 line, -4 lines 0 comments Download
M src/platform-linux.cc View 1 chunk +1 line, -5 lines 0 comments Download
M src/platform-macos.cc View 1 chunk +1 line, -4 lines 0 comments Download
M src/platform-openbsd.cc View 1 chunk +1 line, -5 lines 0 comments Download
M src/platform-qnx.cc View 1 chunk +1 line, -5 lines 0 comments Download
M src/platform-solaris.cc View 1 chunk +1 line, -4 lines 0 comments Download
M src/platform-win32.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
6 years, 6 months ago (2014-06-11 03:10:12 UTC) #1
Michael Starzinger
LGTM.
6 years, 6 months ago (2014-06-11 08:10:38 UTC) #2
jochen (gone - plz use gerrit)
6 years, 6 months ago (2014-06-12 14:11:36 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21810.

Powered by Google App Engine
This is Rietveld 408576698