Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 326303003: Mojo: Expose service names in the JS bindings. (Closed)

Created:
6 years, 6 months ago by Sam McNally
Modified:
6 years, 6 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, chrome-apps-syd-reviews_chromium.org
Visibility:
Public.

Description

Mojo: Expose service names in the JS bindings. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276588

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M mojo/public/tools/bindings/generators/js_templates/interface_definition.tmpl View 3 chunks +5 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/generators/mojom_js_generator.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Sam McNally
6 years, 6 months ago (2014-06-11 07:18:58 UTC) #1
darin (slow to review)
LGTM
6 years, 6 months ago (2014-06-11 14:22:37 UTC) #2
Sam McNally
The CQ bit was checked by sammc@chromium.org
6 years, 6 months ago (2014-06-11 22:54:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sammc@chromium.org/326303003/1
6 years, 6 months ago (2014-06-11 22:56:09 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_dbg_simulator on tryserver.chromium ...
6 years, 6 months ago (2014-06-12 00:14:12 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-12 00:15:39 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/builds/38182) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/15810)
6 years, 6 months ago (2014-06-12 00:15:40 UTC) #7
Sam McNally
The CQ bit was checked by sammc@chromium.org
6 years, 6 months ago (2014-06-12 03:43:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sammc@chromium.org/326303003/1
6 years, 6 months ago (2014-06-12 03:46:39 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_dbg_simulator on tryserver.chromium ...
6 years, 6 months ago (2014-06-12 08:16:07 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 08:42:02 UTC) #11
Message was sent while issue was closed.
Change committed as 276588

Powered by Google App Engine
This is Rietveld 408576698