Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1260)

Unified Diff: runtime/vm/object.cc

Issue 326243002: - Ensure positive keys for private mangling. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object.cc
===================================================================
--- runtime/vm/object.cc (revision 37208)
+++ runtime/vm/object.cc (working copy)
@@ -9311,10 +9311,11 @@
void Library::AllocatePrivateKey() const {
const String& url = String::Handle(this->url());
- intptr_t key_value = url.Hash();
- while (Library::IsKeyUsed(key_value)) {
- key_value++;
+ intptr_t key_value = url.Hash() & kIntptrMax;
+ while ((key_value == 0) || Library::IsKeyUsed(key_value)) {
+ key_value = (key_value + 1) & kIntptrMax;
}
+ ASSERT(key_value > 0);
char private_key[32];
OS::SNPrint(private_key, sizeof(private_key),
"%c%" Pd "", kPrivateKeySeparator, key_value);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698