Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(761)

Unified Diff: extensions/browser/extension_registry_observer.h

Issue 326213004: Invoke callback from WebstoreInstaller when installation is fully complete (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Self nits Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/extension_registry_observer.h
diff --git a/extensions/browser/extension_registry_observer.h b/extensions/browser/extension_registry_observer.h
index 8aa0d079d14e05b5b8d750ab3a0d68a52dd14477..d0b10f3865b410bcb3a8eb7fbbf805bde2651608 100644
--- a/extensions/browser/extension_registry_observer.h
+++ b/extensions/browser/extension_registry_observer.h
@@ -59,7 +59,13 @@ class ExtensionRegistryObserver {
bool from_ephemeral,
const std::string& old_name) {}
- // Called after an extension is uninstalled. The extension no longer exsit in
+ // Called when the installation of |extension| is complete. At this point the
+ // extension is tracked in one of the ExtensionRegistry sets, but is not
+ // necessarily enabled.
asargent_no_longer_on_chrome 2014/06/11 18:27:54 Would it be helpful to pass the enabled/disabled s
tmdiep 2014/06/11 22:56:18 I think maybe not for this notification - it's for
+ virtual void OnExtensionInstalled(content::BrowserContext* browser_context,
+ const Extension* extension) {}
+
+ // Called after an extension is uninstalled. The extension no longer exists in
// any of the ExtensionRegistry sets (enabled, disabled, etc.).
virtual void OnExtensionUninstalled(content::BrowserContext* browser_context,
const Extension* extension) {}
« extensions/browser/extension_registry.cc ('K') | « extensions/browser/extension_registry.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698