Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3480)

Unified Diff: chrome/browser/extensions/webstore_installer.h

Issue 326213004: Invoke callback from WebstoreInstaller when installation is fully complete (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Self nits Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/webstore_installer.h
diff --git a/chrome/browser/extensions/webstore_installer.h b/chrome/browser/extensions/webstore_installer.h
index b35d1e1bb84d518bc4e1fdcdeaae91bba108210f..c31c4c19ed7d515492ce649d1ccde1d2b0cbc071 100644
--- a/chrome/browser/extensions/webstore_installer.h
+++ b/chrome/browser/extensions/webstore_installer.h
@@ -160,7 +160,7 @@ class WebstoreInstaller : public content::NotificationObserver,
// Required minimum version.
scoped_ptr<Version> minimum_version;
- // Ephemeral apps (experimental) are not permanently installed in Chrome.
+ // Ephemeral apps are transiently installed.
bool is_ephemeral;
// The authuser index required to download the item being installed. May be
@@ -199,12 +199,8 @@ class WebstoreInstaller : public content::NotificationObserver,
const content::NotificationDetails& details) OVERRIDE;
// ExtensionRegistryObserver.
- virtual void OnExtensionWillBeInstalled(
- content::BrowserContext* browser_context,
- const Extension* extension,
- bool is_update,
- bool from_ephemeral,
- const std::string& old_name) OVERRIDE;
+ virtual void OnExtensionInstalled(content::BrowserContext* browser_context,
+ const Extension* extension) OVERRIDE;
// Removes the reference to the delegate passed in the constructor. Used when
// the delegate object must be deleted before this object.

Powered by Google App Engine
This is Rietveld 408576698