Invoke callback from WebstoreInstaller when installation is fully complete

extensions/browser/extension_registry.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/extension_registry.h"
 
 #include "base/strings/string_util.h"
 #include "extensions/browser/extension_registry_factory.h"
 #include "extensions/browser/extension_registry_observer.h"
 
@@ skipping 49 matching lines @@
   DCHECK(is_update ==
          GenerateInstalledExtensionsSet()->Contains(extension->id()));
   DCHECK(is_update == !old_name.empty());
   FOR_EACH_OBSERVER(
       ExtensionRegistryObserver,
       observers_,
       OnExtensionWillBeInstalled(
           browser_context_, extension, is_update, from_ephemeral, old_name));
 }
 
+void ExtensionRegistry::TriggerOnInstalled(const Extension* extension) {
+  DCHECK(GenerateInstalledExtensionsSet()->Contains(extension->id()));

[asargent_no_longer_on_chrome, 2014/06/11 18:27:54]

I forget, do the bodies of DCHECK's get completely elided in the build process
if DCHECK's are turned off? If not, you might want to wrap this in:

#if DCHECK_IS_ON

#endif 

Since GenerateInstalledExtensionsSet does a little bit of work. 

[tmdiep, 2014/06/11 22:56:18]

The code doesn't get compiled out completely, but the compiler short circuits
the evaluation so the condition won't execute.

+  FOR_EACH_OBSERVER(ExtensionRegistryObserver,
+                    observers_,
+                    OnExtensionInstalled(browser_context_, extension));
+}
+
 void ExtensionRegistry::TriggerOnUninstalled(const Extension* extension) {
   DCHECK(!GenerateInstalledExtensionsSet()->Contains(extension->id()));
   FOR_EACH_OBSERVER(ExtensionRegistryObserver,
                     observers_,
                     OnExtensionUninstalled(browser_context_, extension));
 }
 
 const Extension* ExtensionRegistry::GetExtensionById(const std::string& id,
                                                      int include_mask) const {
   std::string lowercase_id = StringToLowerASCII(id);
@@ skipping 68 matching lines @@
   disabled_extensions_.set_modification_callback(callback);
 }
 
 void ExtensionRegistry::Shutdown() {
   // Release references to all Extension objects in the sets.
   ClearAll();
   FOR_EACH_OBSERVER(ExtensionRegistryObserver, observers_, OnShutdown(this));
 }
 
 }  // namespace extensions