Clean up temporary git pack files when breaking locks.

Clean up temporary git pack files when breaking locks.

When a git-cache operation is interrupted, it can leave behind large
temporary pack files.  Over time, these pack files will fill up
disks.

R=agable@chromium.org,hinoka@chromium.org,iannucci@chromium.org
BUG=352268
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=276208

[iannucci, 2014-06-10 23:09:08]

lgtm

https://codereview.chromium.org/326203003/diff/1/git_cache.py
File git_cache.py (right):

https://codereview.chromium.org/326203003/diff/1/git_cache.py#newcode368
git_cache.py:368: f.startswith('.tmp-') or f.startswith('tmp_pack_')]
since the name of the file is <hex>.{idx,pack}, why not just `if 'tmp' in f`?

[szager1, 2014-06-10 23:38:28]

https://codereview.chromium.org/326203003/diff/1/git_cache.py
File git_cache.py (right):

https://codereview.chromium.org/326203003/diff/1/git_cache.py#newcode368
git_cache.py:368: f.startswith('.tmp-') or f.startswith('tmp_pack_')]
On 2014/06/10 23:09:08, iannucci wrote:
> since the name of the file is <hex>.{idx,pack}, why not just `if 'tmp' in f`?

Hmm...  Maybe.  I'm a bit paranoid.

[szager1, 2014-06-10 23:38:32]

The CQ bit was checked by szager@chromium.org

[commit-bot: I haz the power, 2014-06-10 23:38:52]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/szager@chromium.org/326203003/1

[commit-bot: I haz the power, 2014-06-10 23:40:50]

Change committed as 276208