Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Issue 326193002: Fix typos in BUILD.gn source lists (Closed)

Created:
6 years, 6 months ago by jamesr
Modified:
6 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix typos in BUILD.gn source lists "foo,cc" is not the same as "foo.cc" R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21765

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jamesr
I'm guessing at a reviewer - please redirect if needed. I'm not a V8 committer, ...
6 years, 6 months ago (2014-06-10 20:11:41 UTC) #1
Michael Starzinger
LGTM, will land this for you.
6 years, 6 months ago (2014-06-11 09:32:54 UTC) #2
Michael Starzinger
6 years, 6 months ago (2014-06-11 09:42:57 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21765 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698