Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 326143002: Remove ui::GetImageScale (Closed)

Created:
6 years, 6 months ago by oshima
Modified:
6 years, 6 months ago
Reviewers:
ananta, sky
CC:
chromium-reviews, browser-components-watch_chromium.org
Visibility:
Public.

Description

Remove ui::GetImageScale * and replace it with ui::GetScaleForScaleFactor * Minor simplification of if blocks in FaviconService BUG=372212 R=ananta@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276421

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : fix mac build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -28 lines) Patch
M chrome/browser/favicon/favicon_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/favicon/favicon_service.cc View 8 chunks +11 lines, -13 lines 0 comments Download
M chrome/browser/favicon/favicon_util.cc View 6 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/layout.h View 1 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
oshima
6 years, 6 months ago (2014-06-10 17:15:59 UTC) #1
ananta
lgtm
6 years, 6 months ago (2014-06-10 21:57:02 UTC) #2
oshima
sky -> owners
6 years, 6 months ago (2014-06-10 21:58:30 UTC) #3
sky
LGTM
6 years, 6 months ago (2014-06-10 22:31:57 UTC) #4
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 6 months ago (2014-06-10 22:45:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/326143002/20001
6 years, 6 months ago (2014-06-10 22:47:30 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_compile_dbg on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 03:57:26 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/15283)
6 years, 6 months ago (2014-06-11 04:32:19 UTC) #8
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 6 months ago (2014-06-11 14:50:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/326143002/40001
6 years, 6 months ago (2014-06-11 14:51:44 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-11 16:13:05 UTC) #11
Message was sent while issue was closed.
Change committed as 276421

Powered by Google App Engine
This is Rietveld 408576698