RenderTextHarfBuzz: Decide run direction by BiDi embedding level

ui/gfx/render_text_unittest.cc

Index: ui/gfx/render_text_unittest.cc
diff --git a/ui/gfx/render_text_unittest.cc b/ui/gfx/render_text_unittest.cc
index 6859a50cf79c85a965bcc7c040672f9b6316b36e..ba1c4abdddba00edd3f6176fbd529004c5b844f3 100644
--- a/ui/gfx/render_text_unittest.cc
+++ b/ui/gfx/render_text_unittest.cc
@@ -1977,4 +1977,16 @@ TEST_F(RenderTextTest, HarfBuzz_CharToGlyph) {
 
 }
 
+TEST_F(RenderTextTest, HarfBuzz_RunDirection) {

[msw, 2014/06/10 20:47:56]

Does this fail without the functional changes of the CL?
(I hope the test would fail if the defect regressed)

[ckocagil, 2014/06/11 07:18:08]

Yes, I tried this by locally reverting the functional part.

+  RenderTextHarfBuzz render_text;
+  const base::string16 mixed =
+      WideToUTF16(L"\x05D0\x05D1" L"1234" L"\x05D2\x05D3");
+  render_text.SetText(mixed);
+  render_text.EnsureLayout();
+  ASSERT_EQ(3U, render_text.runs_.size());
+  EXPECT_EQ(true, render_text.runs_[0]->is_rtl);
+  EXPECT_EQ(false, render_text.runs_[1]->is_rtl);
+  EXPECT_EQ(true, render_text.runs_[2]->is_rtl);
+}
+
 }  // namespace gfx