Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 326113002: GCMDriver.java shouldn't pass on special MultiplexingGcmListener keys (Closed)

Created:
6 years, 6 months ago by johnme
Modified:
6 years, 6 months ago
Reviewers:
fgorski
CC:
chromium-reviews
Visibility:
Public.

Description

GCMDriver.java shouldn't pass on special MultiplexingGcmListener keys MultiplexingGcmListener includes special keys in the intent Bundle like: - com.google.ipc.invalidation.gcmmplex.listener.WAKELOCK_NAME - com.google.ipc.invalidation.gcmmplex.MESSAGE GCMDriver should ignore these, rather than passing them on to C++. BUG=350384 R=fgorski@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276652

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M components/gcm_driver/android/java/src/org/chromium/components/gcm_driver/GCMDriver.java View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
johnme
Minor tweak. No real observable effects, since https://codereview.chromium.org/324913004/ then throws away all keys other than ...
6 years, 6 months ago (2014-06-10 15:53:54 UTC) #1
fgorski
lgtm
6 years, 6 months ago (2014-06-10 16:43:00 UTC) #2
johnme
The CQ bit was checked by johnme@chromium.org
6 years, 6 months ago (2014-06-11 12:37:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/johnme@chromium.org/326113002/1
6 years, 6 months ago (2014-06-11 12:38:35 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 20:55:51 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 21:28:19 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/builds/19569)
6 years, 6 months ago (2014-06-11 21:28:20 UTC) #7
johnme
6 years, 6 months ago (2014-06-12 13:07:47 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 manually as r276652 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698