Use vertex attributes for dash effect in gpu

Use vertex attributes for dash effect in gpu

This will allow us to batch dashed lines together when drawing. Also, this removes the need for
a coord transform matrix in the shader, thus we save the cost of uploading a new matrix uniform
everytime we do a simple transform to the dashed line we are drawing.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/e61c411c1258a323a010558c08de3d9f8d170dca

[egdaniel, 2014-06-10 15:45:31]

Still has two skia and one chrome cl ahead of landing, but this is the main use
vert attributes change to dashing

[bsalomon, 2014-06-11 13:24:44]

https://codereview.chromium.org/326103002/diff/20001/src/gpu/effects/GrDashin...
File src/gpu/effects/GrDashingEffect.cpp (right):

https://codereview.chromium.org/326103002/diff/20001/src/gpu/effects/GrDashin...
src/gpu/effects/GrDashingEffect.cpp:40: // May be able to relax this to include
skew. As of not cannot do perspective
not->now?

https://codereview.chromium.org/326103002/diff/20001/src/gpu/effects/GrDashin...
src/gpu/effects/GrDashingEffect.cpp:157: matrix.mapPoints(&verts[idx].fPos, 1);
Not sure if it's clearer, but there is a mapPointsWithStride().

https://codereview.chromium.org/326103002/diff/20001/src/gpu/effects/GrDashin...
src/gpu/effects/GrDashingEffect.cpp:317: GrAARectRenderer* aaRectRenderer =
SkNEW(GrAARectRenderer);
Hmm... it seems a bit expensive to cons up an object here to draw a rect. I'm
pretty sure it will create a new index buffer. We should figure out how to share
the one we have.

[egdaniel, 2014-06-11 21:34:47]

ptal

[bsalomon, 2014-06-11 21:43:37]

lgtm w/ question about whether we really need to copy a paint.

https://codereview.chromium.org/326103002/diff/60001/src/gpu/SkGpuDevice.cpp
File src/gpu/SkGpuDevice.cpp (right):

https://codereview.chromium.org/326103002/diff/60001/src/gpu/SkGpuDevice.cpp#...
src/gpu/SkGpuDevice.cpp:391: GrStrokeInfo strokeInfo(p);
Do we need to construct this from a paint if we know the style is kStroke?

[egdaniel, 2014-06-12 12:13:11]

https://codereview.chromium.org/326103002/diff/60001/src/gpu/SkGpuDevice.cpp
File src/gpu/SkGpuDevice.cpp (right):

https://codereview.chromium.org/326103002/diff/60001/src/gpu/SkGpuDevice.cpp#...
src/gpu/SkGpuDevice.cpp:391: GrStrokeInfo strokeInfo(p);
On 2014/06/11 21:43:37, bsalomon wrote:
> Do we need to construct this from a paint if we know the style is kStroke?

Added an optional parameter to ctor of strokeInfo to force stroke style to be
set (and thus remove the paint cpy)

[egdaniel, 2014-06-12 15:33:13]

Added constructor to override the stroke style in GrStrokeInfo and SkStrokeRec

[bsalomon, 2014-06-12 15:42:36]

lgtm

[egdaniel, 2014-06-12 15:50:17]

The CQ bit was checked by egdaniel@google.com

[commit-bot: I haz the power, 2014-06-12 15:51:04]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/egdaniel@google.com/326103002/120001

[commit-bot: I haz the power, 2014-06-12 16:20:28]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  Build-Win7-VS2010-x86-Debug-Trybot on tryserver.skia
(http://108.170.220.76:10117/builders/Build-Win7-VS2010-x86-Debug-Trybot/build...)

[egdaniel, 2014-06-12 16:54:34]

The CQ bit was unchecked by egdaniel@google.com

[egdaniel, 2014-06-12 16:57:44]

The CQ bit was checked by egdaniel@google.com

[commit-bot: I haz the power, 2014-06-12 16:58:46]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/egdaniel@google.com/326103002/140001

[commit-bot: I haz the power, 2014-06-12 17:24:30]

Change committed as e61c411c1258a323a010558c08de3d9f8d170dca