MacViews: Enable RenderTextHarfBuzz to get Textfields to work.

ui/gfx/render_text.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/gfx/render_text.h"
 
 #include <algorithm>
 #include <climits>
 
 #include "base/command_line.h"
@@ skipping 394 matching lines @@
   SkTypeface::Style skia_style = ConvertFontStyleToSkiaTypefaceStyle(style);
   return skia::AdoptRef(SkTypeface::CreateFromName(family.c_str(), skia_style));
 }
 
 }  // namespace internal
 
 RenderText::~RenderText() {
 }
 
 RenderText* RenderText::CreateInstance() {
+#if defined(OS_MACOSX) && defined(TOOLKIT_VIEWS)
+  // views::Textfield requires RenderTextHarfBuzz on Mac because RenderTextMac's

[msw, 2014/06/10 23:23:47]

nit: Textfield is the heaviest user, but I'm planning on converting views::Label
to cache RenderText instances. You could generalize the comment to something
like "Use the more complete HarfBuzz implementation for Views controls on Mac."

+  // implementation is not complete.
+  return new RenderTextHarfBuzz;
+#else
   if (CommandLine::ForCurrentProcess()->HasSwitch(
           switches::kEnableHarfBuzzRenderText)) {
     return new RenderTextHarfBuzz;
   }
   return CreateNativeInstance();
+#endif
 }
 
 void RenderText::SetText(const base::string16& text) {
   DCHECK(!composition_range_.IsValid());
   if (text_ == text)
     return;
   text_ = text;
 
   // Adjust ranged styles and colors to accommodate a new text length.
   const size_t text_length = text_.length();
@@ skipping 900 matching lines @@
   cursor_bounds_ += delta_offset;
 }
 
 void RenderText::DrawSelection(Canvas* canvas) {
   const std::vector<Rect> sel = GetSubstringBounds(selection());
   for (std::vector<Rect>::const_iterator i = sel.begin(); i < sel.end(); ++i)
     canvas->FillRect(*i, selection_background_focused_color_);
 }
 
 }  // namespace gfx