Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 326073003: Reduce size of HTMLCollection / LiveNodeList / ChildNodeList by 1 word (Closed)

Created:
6 years, 6 months ago by Inactive
Modified:
6 years, 6 months ago
Reviewers:
esprehn
CC:
blink-reviews, blink-reviews-html_chromium.org, dglazkov+blink
Visibility:
Public.

Description

Reduce size of HTMLCollection / LiveNodeList / ChildNodeList by 1 word Reduce size of HTMLCollection / LiveNodeList / ChildNodeList by 1 word by updating the bitfield in CollectionIndexCache so that m_cachedNodeIndex and m_isLengthCacheValid share 32 bits. Otherwise, the compiler was adding padding bits after m_isLengthCacheValid to get proper memory alignment. On my 64 bit Linux machine with gcc 4.8, I see the following size changes: * HTMLCollection: 72 bytes -> 64 bytes * LiveNodeList: 72 bytes -> 64 bytes * ChildNodeList: 56 bytes -> 48 bytes I ran PerformanceTests/Bindings/node-list-access.html performance test and could not see any performance impact with this CL. R=esprehn@chromium.org BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176603

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/core/html/CollectionIndexCache.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Inactive
6 years, 6 months ago (2014-06-10 15:16:23 UTC) #1
esprehn
lgtm, seems reasonable.
6 years, 6 months ago (2014-06-20 08:17:52 UTC) #2
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 6 months ago (2014-06-20 11:50:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/326073003/1
6 years, 6 months ago (2014-06-20 11:50:43 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-20 11:54:17 UTC) #5
Message was sent while issue was closed.
Change committed as 176603

Powered by Google App Engine
This is Rietveld 408576698